Decision 0028 · Accepted
Build opens the pull request; ship lands
accepted work
"Ship it" stops twice, for a plan confirmation and a main gate, although users say it once they have decided.
- Status
- Accepted
- Built from:
- da88c48
Status: Accepted (2026-10-28). Amends 0019 (ship confirms before pushing), 0021 (one push confirmation per run; merging needs authorization), 0024 (ship's plan confirmation and main gate; a yes to the shown text before writing a spec), and 0025 (waves move from ship to build; the deploy target is retired). Spec: 017. Amended by 0029 (the accepted label is the gate in pull-request mode; one independent review per spec, in ship). Amended by 0030 (local ship pushes main only on request). Amended by 0032 (ship verifies the shipped commit on its deployment; local build merges into local main). Amended by 0042 (ship lands when the implementation and the independent review are done; a named build then review pipeline is not required once those proofs are met). Amended by 0044 (build ends with an open pull request and never waits on CI; ship owns the only CI wait and lands both delivery modes). Amended by 0058 (three review rounds).
Context
"Ship it" stops twice, for a plan confirmation and a main gate, although users say it once they have decided. "Build it" ends in local changes, while what users want to check is a pull request: CI runs on it and attaches whatever environment the project's pipeline builds. Skills that know about specific deploy platforms add configuration without adding behavior. Nothing marks a spec as reviewed, so nothing separates work that is ready to land from a draft.
Decision
- "Build it" ends in a pull request with green checks.
implementis renamedbuild. It implements from a spec's tasks or from the request, opens a pull request, and waits for its checks, running fix rounds on failures. It reports the pull request, the check results, and the links CI attached. On a task set it runs the waves and checkpoints from 0025; checkpoints report the pull request's checks and links and do not wait unless asked. In local mode, build runs the local check suite on a branch instead. No confirmation; build never pushesmain. - Spec acceptance. Specs gain the status
accepted(candidate → draft → accepted → implemented).to-specwrites the spec file asdraft, and any decision proposed beside it as Proposed, without showing the text inline or asking first; it reports links to the files. When the user approves a spec for delivery,to-specsets the spec toacceptedand its linked decisions to Accepted. - "Ship it" lands work with no confirmation. For spec work, ship first requires an
acceptedspec and Accepted linked decisions; otherwise it names what is missing and stops without building. It then builds if no pull request exists, runs an adversarial five-axisreviewwith a separate worker, posts the review on the pull request, runs up to two fix rounds, waits for green checks, sets the spec toimplemented, merges, deletes the head branch, and fast-forwards localmain. In local mode it merges with--no-ffand pushesmain. - Hotfixes. Work with no spec and no task ships through the same cycle. The review also judges whether the change is hotfix-sized: new product behavior, a data-shape or public API change, or a migration is a blocking finding, and ship stops and suggests
to-spec. - The review is the gate. Ship merges only when checks are green, no findings are blocking, and branch protection is satisfied. The agent never approves its own pull request and never bypasses protection (for example
gh pr merge --admin). When protection requires a human approval, ship stops and reports. Without a separate worker, the review is labelled single-agent on the pull request and still gates. - No deploy target. The Flow block drops
Deploy:. Environments are the pipeline's job; skills read what the pull request shows. - Chained skills.
shiprunsbuildandreviewas part of landing, beside the automatic hand-offs 0024 lists. - Unchanged. No destructive Git, no force-push, no production promotion unless asked; publishing task records still needs a yes to the shown list (0024).
Rationale
The human review moves to where it carries information: the spec and its decisions, before any code. A draft file is cheap to write and easier to read than inline text, so the yes belongs to acceptance, not to saving. Once those are accepted, "ship it" is the authorization, and an independent review with green checks is a stronger gate than a yes to a summary. Misheard dictation is bounded: build never pushes main, ship refuses unaccepted specs, and a stray ad-hoc change must pass the hotfix test. Reading the pull request instead of a platform keeps skills working on any CI/CD.
Alternatives
- Keep only the main gate. Rejected: "ship it" should finish.
- Treat a saved spec as reviewed. Rejected: drafts are saved to be read, not to be landed.
- Keep the yes before saving a spec. Rejected: it duplicates acceptance and makes the user review long text inline.
- Approve through a bot identity. Deferred: it needs setup in every project, and the posted review carries the same evidence.
- Keep
Deploy:for checkpoint previews. Rejected: the pull request already shows the pipeline's links. - Keep the name
implement. Rejected: the spoken verb and the skill name would differ.
Consequences
- Local mode pushes
mainwith no human yes; it relies on spec acceptance, checks, and review. - Existing
Deploy:lines are dropped the next time the block is rewritten. - Adopters keep a stale
implementskill until they reinstall; the release notes say so. - The board treats
acceptedas a known status, and its live run overlay is recorded bybuild.